PROD-2323 Add-tabs-to-display-monitored-and-ignored-schema-in-Data-Detection #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 22, 2024 13:57
…s-to-display-monitored-and-ignored-schema-in-Data-Detection
…tion-Discovery-Breadcrumbs' of github.com:ethyca/fides into PROD-2323-Add-tabs-to-display-monitored-and-ignored-schema-in-Data-Detection
…onited. Do the same for unmonitored.
…ema-in-Data-Detection' of github.com:ethyca/fides into PROD-2323-Add-tabs-to-display-monitored-and-ignored-schema-in-Data-Detection
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added 2 commits
August 27, 2024 10:57
…tion filter tabs.
…tion filter tabs.
added 2 commits
August 28, 2024 10:01
…s-to-display-monitored-and-ignored-schema-in-Data-Detection
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5236/merge
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Lucano Vera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
|
At 1280 wide, these buttons get squished. Likely not caused by your work here, but something to address while we're here maybe?
|
…from getting too small
Good catch. I just pushed a change adding a column width of 180 for the action column. It shouldn't shrink past that now.
|
gilluminate
approved these changes
Aug 28, 2024
CHANGELOG.md
Outdated
| @@ -20,6 +20,9 @@ The types of changes are: | |||
| ### Added | |||
| - Added Gzip Middleware for responses [#5225](https://github.com/ethyca/fides/pull/5225) | |||
| - Adding source and submitted_by fields to privacy requests (Fidesplus) [#5206](https://github.com/ethyca/fides/pull/5206) | |||
| - Added Action Required / Monitored / Unmonitored tabs to Data Detection page [#5236](https://github.com/ethyca/fides/pull/5236) | |||
| - Added Action Required / Unmonitored tabs to Data Discovery page [#5236](https://github.com/ethyca/fides/pull/5236) | |||
There was a problem hiding this comment.
this second line can likely be removed as redundant?
| initialFilterTabIndex: router.query?.filterTabIndex | ||
| ? Number(router.query?.filterTabIndex) | ||
| : undefined, | ||
| }); |
…ignored-schema-in-Data-Detection
lucanovera
deleted the
PROD-2323-Add-tabs-to-display-monitored-and-ignored-schema-in-Data-Detection
branch
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Lucano Vera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
In Data Detection, add tabs to display Monited, Ignored Schema and Action Required.
Code Changes
Screenshots
Data Detection > Action Required Tab
Data Detection > Monitored Tab
Data Detection > Unmonitored Tab
Data Discovery > Action Required Tab
Data Discovery > Unmonitored Tab
Steps to Confirm
Go to the Data Detection page
Check that using the Monitored tab it displays the Monitored status items only and that the icon for the changeType is monitored (green dot). Also the status column should read Monitored and the action column show only have the Ignore button.
Check that using the Unmonitored tab it displays the Unmonitored status items only and that the icon for the changeType is unmonitored (red dot). Also the status column should read Unmonitored and the action column show only have the Monitor button.
Check that you can navigate up and down the datasets while keeping the tab filter the same
Go to the Data Disocvery page
Check that using the Unmonitored tab it displays the Unmonitored status items only and that the icon for the changeType is unmonitored (red dot). Also the status column should read Unmonitored and the action column show no actions (decided best not to try to add this now, since there's a new UI version of DnD coming soon that solves these problems)
Check that you can navigate up and down the datasets while keeping the tab filter the same
Pre-Merge Checklist
CHANGELOG.md